[Bug 735795] imagefreeze: missing gst_caps_unref

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735795
  GStreamer | gst-plugins-good | unspecified

--- Comment #4 from Vineeth <vineeth.tm at samsung.com> 2014-09-01 09:14:18 UTC ---
Hi Sebastian,
   Thanks for the review.

   The reason i added the first case was, when the function was being called,

      GstCaps *caps;

      gst_query_parse_caps (query, &caps);
      caps = gst_image_freeze_sink_getcaps (self, caps);
      gst_query_set_caps_result (query, caps);
      gst_caps_unref (caps);

   i am guessing the function, gst_image_freeze_sink_getcaps() was written such
that, the caps argument being passed is supposed to be unref and a new ref
needs to be created for the result caps, similar to how gst_caps_copy()
functions.

   this can be confirmed from the below call in gst_image_freeze_sink_getcaps()

  if (filter) {
    filter = gst_caps_copy (filter);
    gst_image_freeze_remove_fps (self, filter);
  }
  where using the call, gst_caps_copy (filter), we are unref'ing the filter
owned by caller and creating a new reference to be used.

  Can you confirm once if my understanding is correct.

Regards,
Vineeth

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.