[Bug 728326] Check for return values of gst_buffer_map and gst_memory_map

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Sep 1 02:15:10 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=728326
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284984|none                        |reviewed
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-01 09:15:04 UTC ---
Review of attachment 284984:
 --> (https://bugzilla.gnome.org/review?bug=728326&attachment=284984)

::: plugins/elements/gstfakesink.c
@@ +481,3 @@
+      gst_util_dump_mem (info.data, info.size);
+      gst_buffer_unmap (buf, &info);
+    }

Maybe an else case that says that the buffer couldn't be mapped? Or a
GST_WARNING or something? Also in the other elements

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list