[Bug 728326] Check for return values of gst_buffer_map and gst_memory_map

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Sep 1 02:17:30 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=728326
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284983|none                        |accepted-commit_now
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-01 09:17:26 UTC ---
Review of attachment 284983:
 --> (https://bugzilla.gnome.org/review?bug=728326&attachment=284983)

::: gst/gstbuffer.c
@@ +248,3 @@
+        gst_memory_unmap (result, &dinfo);
+      } else if (result) {
+        GST_WARNING ("Can't get writable GstMemory to copy/contatenate
buffer");

typo: contatenate

And maybe just say "merge" instead of "copy/concatenate"?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list