[Bug 735795] imagefreeze: missing gst_caps_unref

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735795
  GStreamer | gst-plugins-good | unspecified

--- Comment #8 from Vineeth <vineeth.tm at samsung.com> 2014-09-01 11:28:59 UTC ---
Created an attachment (id=284992)
 View: https://bugzilla.gnome.org/attachment.cgi?id=284992
 Review: https://bugzilla.gnome.org/review?bug=735795&attachment=284992

Update the patch as per review comments

hmmm. I have updated the patch by removing 1st case..



Actually my confusion arises from the below definition given in reference
manual. It states, gst_caps_copy() is equivalent to
gst_caps_make_writable(gst_caps_ref()), so i thought the behavior of
gst_caps_copy() will be similar to gst_caps_make_writable()

gst_caps_copy ()

GstCaps *           gst_caps_copy                       (const GstCaps *caps);

Creates a new GstCaps as a copy of the old caps. The new caps will have a
refcount of 1, owned by the caller. The structures are copied as well.

Note that this function is the semantic equivalent of a gst_caps_ref() followed
by a gst_caps_make_writable(). If you only want to hold on to a reference to
the data, you should use gst_caps_ref().

When you are finished with the caps, call gst_caps_unref() on it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.