[Bug 735804] smpte: Pipeline throws "Internal dataflow error"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735804
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284993|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-01 11:39:56 UTC ---
Review of attachment 284993:
 --> (https://bugzilla.gnome.org/review?bug=735804&attachment=284993)

::: gst/smpte/gstsmpte.c
@@ +302,3 @@

+  if (smpte->src_caps == NULL
+      || gst_caps_is_equal (caps, smpte->src_caps) == FALSE) {

Don't check gbooleans with ==. Just do || gst_caps_is_equal())

@@ +386,3 @@
+  if (smpte->src_caps) {
+    gst_caps_replace (&smpte->src_caps, NULL);
+    smpte->src_caps = NULL;

The caps should already be cleared in PAUSED→READY state change

@@ +532,3 @@
       GstSegment segment;

+      gst_pad_set_caps (smpte->srcpad, smpte->src_caps);

Why not just forward the caps directly from the setcaps function by calling
gst_pad_set_caps() from there? Also what do you do if both sinkpads have
different caps that are nonetheless compatible for the smpte element?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.