[Bug 735861] New: dataurisrc: make src thread safe

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735861
  GStreamer | gst-plugins-bad | unspecified

           Summary: dataurisrc: make src thread safe
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: vineeth.tm at samsung.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


In gst_data_uri_src_get_uri(),

src is not thread safe.

Added extra conditions to make it thread safe.
Please review.


And i have one doubt,
in gst_data_uri_src_create() function, there is a condition

else if (*buf != NULL) {

which will be used when buffer is already provided. But is there any scenario
where buffer will be provided as input?

if buffer is provided, then dont we need to check the size of the buffer
allocated with the size of source buffer?
I was thinking, that else if condition should be executed only when size of
provided buffer will be same as size of source buffer..
or we can remove else if condition
and something like
else {
    if (*buf != NULL)
        gst_buffer_unref(*buf);
    *buf =
        gst_buffer_copy_region (src->buffer, GST_BUFFER_COPY_ALL, offset,
size);
    ret = GST_FLOW_OK;
  }

Please correct me if i am wrong

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.