[Bug 735357] pad: should not allow flush-stop on inactive pads

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735357
  GStreamer | gstreamer (core) | git

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.5.1

--- Comment #2 from Wim Taymans <wim.taymans at gmail.com> 2014-09-02 10:11:05 UTC ---
commit 7e33f52961d0215d8be10657417e6889bf9cc518
Author: Wim Taymans <wtaymans at redhat.com>
Date:   Mon Aug 25 11:34:48 2014 +0200

    tests: add flush-stop on inactive pad test

    Check that pushing flush-stop on an inactive pad does not clear the
    flushing flag.

commit 060b16ac75ac227d4cfe1db89ccdc4f4b31545ff
Author: Wim Taymans <wtaymans at redhat.com>
Date:   Thu Aug 21 15:49:17 2014 +0200

    pad: don't accept flush-stop on inactive pads

    Inactive pads should at all times have the flushing flag set. This means
    that when we get a flush-stop on an inactive pad we must ignore it.

    On sinkpads, make this more explicit. We used to not clear the flush
    flag but remove the events and then return an error because the flushing
    flag was set. Now just simply refuse the event without doing anything.

    On srcpads, check that we are trying to push a flush-stop event and
    refuse it. We would allow this and mark the srcpad as non-flushing
    anymore.

    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=735357

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.