[Bug 735879] New: basetetxtoverlay: make shading_value a property

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Sep 2 04:17:27 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=735879
  GStreamer | gst-plugins-base | 1.x

           Summary: basetetxtoverlay: make shading_value a property
    Classification: Platform
           Product: GStreamer
           Version: 1.x
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: lists at svrinformatica.it
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=285129)
 View: https://bugzilla.gnome.org/attachment.cgi?id=285129
 Review: https://bugzilla.gnome.org/review?bug=735879&attachment=285129

make shading_value a property

shading_value is hardcoded to 80 (1-255 range), this patch make it
configurable.

I don't understand this code:

http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/ext/pango/gstbasetextoverlay.c#n1554

cairo_paint_with_alpha require a double while shading_value is an integer

however background shading is done in methods like these:

http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/ext/pango/gstbasetextoverlay.c#n1633

http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/ext/pango/gstbasetextoverlay.c#n1652

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list