[Bug 736028] basetextoverlay: cairo transparence

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736028
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |slomo at coaxion.net
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.5.1

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-04 11:14:46 UTC ---
commit 501a295fa12436ffd2f1abc7105b007ecc9f950a
Author: Nicola Murino <nicola.murino at gmail.com>
Date:   Thu Sep 4 12:13:45 2014 +0200

    basetextoverlay: remove unneeded cairo transparence setting

    he code here:

   
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/ext/pango/gstbasetextoverlay.c#n1554

    should make transparent the box that contains the text, I think this code
is
    not correct, it should be:

    if (overlay->want_shading) {
        double alpha = overlay->shading_value / 255.0;
        cairo_paint_with_alpha (cr, alpha);
      }

    however I think this code could be removed, we already do a shaded
background,
    why shade the box behind the text with cairo too? only one shading is
needed so
    we must shade with cairo or with methods like these:

   
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/ext/pango/gstbasetextoverlay.c#n1642

    not both

    https://bugzilla.gnome.org/show_bug.cgi?id=736028

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.