[Bug 733661] glimagesink navigation interface causes hangs with X11/GMainLoop event thread

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733661
  GStreamer | gst-plugins-bad | git

--- Comment #4 from Vasilis Liaskovitis <vliaskov at gmail.com> 2014-09-04 11:19:40 UTC ---
(In reply to comment #2)
thanks for reviewing

> Review of attachment 284623 [details]:
>
> Looks good, some comments below.
>
> (In reply to comment #1)
> > The navigation thread is currently part of GstGLWindow and not implemented in
> > separate subclasses / backends yet. Perhaps this is needed?
>
> It will be needed at some point :)

ok. So should I work on it (i.e. making only dummy and x11 subclass
implementation for now) or leave it in GstGLWindow for first inclusion?

>
> > Also commit 4dacc4ba introduced get_surface_dimensions method. The problem for
> > the X11 backend, is that now this function is called from the navigation
> > thread, resulting in xlib aborting due to multithreaded access:
>
> For x11 it would make sense to store the window dimensions in the subclass and
> return the cached values in get_surface_dimensions ().  The other backends will
> most likely be fine with all of this.

makes sense, I 'll try this.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.