[Bug 736058] [PATCH] adding one example to use gnlsource and gnlcomposition in gstreamer pipeline

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736058
  GStreamer | gnonlin | unspecified

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285383|none                        |reviewed
             status|                            |

--- Comment #2 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-09-04 15:02:23 UTC ---
Review of attachment 285383:
 --> (https://bugzilla.gnome.org/review?bug=736058&attachment=285383)

This code look good in general. As an example it should probably be commented,
what do you think ?

::: tests/examples/gstextractor.c
@@ +1,1 @@
+/*

Normally there should be copyright and licensing here. For an example you can
make it as-is, it's your choice.

@@ +54,3 @@
+  g_strfreev (timev);
+  return (guint64) (time * GST_SECOND);
+}

Just wondering, but can't gst_date_time_new_from_iso8601_string() can be used
here ? We do this kind of conversion in GST in general, I would be suprised if
there is no utility for it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.