[Bug 733614] Zero copy path between omxvideodec and v4l2sink

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733614
  GStreamer | gst-omx | git

--- Comment #18 from Aurélien Zanelli <aurelien.zanelli at parrot.com> 2014-09-04 16:08:20 UTC ---
(In reply to comment #17)
> Review of attachment 282425 [details]:
> 
> Looks good overall, except the fallthrough, but maybe you have a good reason,
> let me know.
> 
> ::: omx/gstomxvideodec.c
> @@ +2614,3 @@
> +    if (!gst_buffer_pool_config_validate_params (config, caps, size, min,
> max)) {
> +      GST_DEBUG_OBJECT (dec,
> +          "can't configure pool to suit our needs, copy to downstream pool");
> 
> I think we should fail at this point. Otherwise the corrected (but not
> acceptable) config will be set on line 2619, which will pretty much always
> succeed, and lead to pipeline that most of the time will stall rather then
> fail.

In fact, I don't think so, because omxvideodec always use OMX buffers. If
provided pool doesn't suit, instead of giving its internal buffer, it will
acquire one from pool and copy frame to it. See comment #12 for more details.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.