[Bug 733661] glimagesink navigation interface causes hangs with X11/GMainLoop event thread

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733661
  GStreamer | gst-plugins-bad | git

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285414|none                        |reviewed
             status|                            |

--- Comment #6 from Matthew Waters <ystreet00 at gmail.com> 2014-09-05 05:54:51 UTC ---
Review of attachment 285414:
 --> (https://bugzilla.gnome.org/review?bug=733661&attachment=285414)

::: gst-libs/gst/gl/gstglwindow.c
@@ +242,3 @@

+  window->priv->navigation_thread = g_thread_new ("gstglnavigation",
+      (GThreadFunc) gst_gl_window_navigation_thread, window);

I'm not sure if it matters but this is racy with event sending from backends. 
The thread could have not been created yet when the backends try to send events
through it.

You might want to look at the gst_gl_context_create in gstglcontext.c for some
inspiration.

@@ +347,2 @@
 /**
+ * gst_gl_window_run:

run_navigation

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.