[Bug 735991] pcapparse: add support for IPv6

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735991
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285409|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-05 07:57:11 UTC ---
Review of attachment 285409:
 --> (https://bugzilla.gnome.org/review?bug=735991&attachment=285409)

Thanks for the patch :)

::: gst/pcapparse/gstpcapparse.c
@@ +63,3 @@
   PROP_DST_IP,
+  PROP_SRC_IP6,
+  PROP_DST_IP6,

It should be possible to re-use the existing IP properties, and detect if the
string is an IPv6 or IPv4 IP.

@@ +256,3 @@
+    return FALSE;
+
+  //ret can be 1,0 or -1

No C99 comments

@@ +563,3 @@
   guint16 len;
+  struct in6_addr ip6_src_addr = { {{0}} };     /* This triple braces is a
workaround for GCC bug 53119 */
+  struct in6_addr ip6_dst_addr = { {{0}} };     /* this triple braces is a
workaround for GCC bug 53119 */

Maybe just memset()?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.