[Bug 736071] audiobasesink: Don't hold object lock while calling into other objects like the clock

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736071
  GStreamer | gst-plugins-base | 1.2.1

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285401|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-05 08:06:54 UTC ---
Review of attachment 285401:
 --> (https://bugzilla.gnome.org/review?bug=736071&attachment=285401)

Can you attach the patch in "git format-patch" format?

::: gst-libs/gst/audio/gstaudiobasesink.c
@@ +1482,1 @@
   itime = gst_audio_clock_adjust (sink->provided_clock, itime);

Move the "etime = ..." line below this, and keep the lock unlocked for both
"itime = ..." lines. Releasing the lock here seems safe considering the other
code using the clock and the code above these lines

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.