[Bug 732908] audioresample skips samples unless input buffers have correct size

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732908
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-05 08:21:29 UTC ---
Pushed but it would be good if you could provide a unit test to prevent that we
introduce changes later that break it again :) Keeping this bug open for now.


commit 684cf44ee3c8ccdbcc2f5711f050ba57d9909183
Author: Kipp Cannon <kipp.cannon at ligo.org>
Date:   Tue Jul 8 12:37:41 2014 -0400

    audioresample: don't skip input samples

    when downsampling, the output buffer can be filled before all the input
    samples are consumed.  this is correct:  when downsampling, several input
    samples are needed for each output sample, so when only a small number of
    input samples are available the number of output samples produced can be 0.

    the resampler, however, was discarding those extra input samples instead of
    clocking them into its filter history for the next iteration.  this patch
    fixes this by removing the check that the output buffer is full.  the code
    now always loops until all input samples are consumed, and relies on the
    calling code to have provided a suitably sized location for the output.
    note that there are already other checks in place in the calling code to
    ensure that this is the case.

    https://bugzilla.gnome.org/show_bug.cgi?id=732908

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.