[Bug 736118] videofilter: The buffer is not writable in transform_frame_ip

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736118
  GStreamer | gst-plugins-base | 1.4.1

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285480|reviewed                    |accepted-commit_now
             status|                            |

--- Comment #10 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-09-08 02:18:29 UTC ---
Review of attachment 285480:
 --> (https://bugzilla.gnome.org/review?bug=736118&attachment=285480)

Ok, the context is a bit missing in the patch itself, but as we map the frame
(hence ref the buffer), unref the buffer, transform frame, ref buffer and
finally unmap the frame (hence unref the buffer), this patch clearly works. It
a weird dance, but it clearly show that we know what we are doing. I like the
flag in the end, but we need this method first in the likely case we want to
backport to 1.4. Feel free to introduce the flag in 1.5 though, then it would
be worth adding this change at the other places (e.g. in OpenCV elements base
class, which isn't base on VideoFilter).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.