[Bug 736252] New: gdkpixbufdec: packetized mode logic

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736252
  GStreamer | gst-plugins-good | unspecified

           Summary: gdkpixbufdec: packetized mode logic
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: vineeth.tm at samsung.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


To check packetized mode the logic being used is 

  /* packetised mode? *//* FIXME: shouln't this be fps_d != 0, since 0/1
   * might be packetised mode but variable framerate */
  if (filter->in_fps_n != 0) {

I guess the logic is correct, since if numerator is 0, it will be considered as
a single image. In that case FIXME should be removed right?

And i am getting confused, with the logic used in pngdec element

  if (GST_VIDEO_INFO_FPS_N (info) != 1 && GST_VIDEO_INFO_FPS_D (info) != 1)
    gst_video_decoder_set_packetized (decoder, TRUE);

Isn't this wrong? 1/1 framerate is also packetized mode right?
Shouldn't the condition be, to check for numerator != 0, similar to
gdkpixbufdec?

  if (GST_VIDEO_INFO_FPS_N (info) != 0 && GST_VIDEO_INFO_FPS_D (info) != 1)
    gst_video_decoder_set_packetized (decoder, TRUE);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.