[Bug 736017] Sequence number not monotonic in RTSP server with basepayload component

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736017
  GStreamer | gst-plugins-base | 1.4.0

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285637|none                        |reviewed
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-08 15:45:09 UTC ---
Review of attachment 285637:
 --> (https://bugzilla.gnome.org/review?bug=736017&attachment=285637)

::: gst/rtsp-server/rtsp-media.c
@@ +2719,3 @@
+  guint16 seq_num;
+  seq_num = gst_rtsp_stream_get_seqnum (stream);
+  gst_rtsp_stream_set_seqnum (stream, seq_num + 1);

Just these two lines seem weird :) Maybe rename the functions to
get_current_seqnum() and set_seqnum_offset()?

Otherwise looks good to me

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.