[Bug 733682] waylandsink: allow catching input events

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733682
  GStreamer | gst-plugins-bad | 1.4.0

--- Comment #2 from George Kiagiadakis <george.kiagiadakis at collabora.com> 2014-09-10 13:45:27 UTC ---
Hello,

I am fine with that patch, given that you have tested it and works ok. I am not
confident yet with the input event handling in general, because I haven't
studied that part enough yet and I have seen problems in strange interactions
with the embedder toolkit, but for the standalone mode it should be fine.

I only have one comment regarding the code of the patch, I would prefer it if
you used gst_wl_window_is_toplevel() in the if() check instead of using
window->display->own_display. At the moment both checks have the same effect,
but I'd rather maintain the state of the window inside the window class instead
of looking at the internals of the display class.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.