[Bug 736460] mpegpsmux: refactor duplicate else branches

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Sep 11 02:41:01 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=736460
  GStreamer | gst-plugins-bad | 1.x

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
                 CC|                            |t.i.m at zen.co.uk

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-09-11 09:40:58 UTC ---
Not convinced this is a worthwhile change. If we remove the value for the
unknown case there really should be an else g_assert_not_reached() then or so,
to make sure things are still set up properly if someone adds subtitle support
in future, for example. I'd suggest to just leave it as is.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list