[Bug 736035] glimagesink: Regression: Gtk+ cannot get glimagesink input

Thu Sep 11 04:22:14 PDT 2014

https://bugzilla.gnome.org/show_bug.cgi?id=736035
  GStreamer | gst-plugins-bad | unspecified

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285893|none                        |needs-work
             status|                            |

--- Comment #4 from Matthew Waters <ystreet00 at gmail.com> 2014-09-11 11:22:11 UTC ---
Review of attachment 285893:
 --> (https://bugzilla.gnome.org/review?bug=736035&attachment=285893)

In addition to the issues mentioned in the previous comment.

Make the function names similar to the video overlay interface method.
Something like gst_glimage_sink_set_handle_events or remove the 'set'.  Up to
you.  Repeat for the other objects.

Otherwise, it looks good.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.