[Bug 736490] tsdemux: fix overflow of packet_length field of PESHeader

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Sep 12 02:33:47 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=736490
  GStreamer | gst-plugins-bad | 1.x

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |bilboed at bilboed.com
         Resolution|                            |FIXED

--- Comment #4 from Edward Hervey <bilboed at bilboed.com> 2014-09-12 09:33:43 UTC ---
(should also be backported to 1.4 branch imho)


commit 6d767a09d8b85918304115255dbaacdac644a7d2
Author: Aurélien Zanelli <aurelien.zanelli at parrot.com>
Date:   Thu Sep 11 18:33:20 2014 +0200

    tsdemux: fix overflow of packet_length field of PESHeader

    packet_length is defined as a guint16 in the PESHeader structure. This
    definition match the specification. But since we add 6 bytes to the
    packet_length value (length of start_code + stream_id + packet_length),
    we can overflow the guint16 when the value in the PES header is greater
    than 65529.
    So use a guint32 instead of a guint16 to avoid overflow.

    https://bugzilla.gnome.org/show_bug.cgi?id=736490

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list