[Bug 736477] check: Add a function to check destruction of objects

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Sep 12 06:17:56 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=736477
  GStreamer | gstreamer (core) | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285915|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-12 13:17:55 UTC ---
Review of attachment 285915:
 --> (https://bugzilla.gnome.org/review?bug=736477&attachment=285915)

::: libs/gst/check/gstcheck.c
@@ +943,3 @@
+ * destroyed, also checks that the other objects passed in
+ * parametter have been destroyed as a concequence of
+ * unrefing @object_to_unref. Last variable argument should be NULL.

Please document that first_object can be NULL, and add a convenience function
for that case :)

Also Since: 1.6

@@ +957,3 @@
+
+  if (first_object) {
+    va_list varargs;

I think you have to call va_start/end also if first_object is NULL but not
sure.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list