[Bug 735844] basetextoverlay/pango: overlay negotiation fails when it should not

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735844
  GStreamer | gst-plugins-base | 1.4.1

--- Comment #26 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-09-12 13:36:16 UTC ---
@@ -780,7 +781,7 @@ gst_base_text_overlay_negotiate (GstBaseTextOverlay *
overlay, GstCaps * caps)
     if (!gst_pad_peer_query (overlay->srcpad, query)) {
       /* no problem, we use the query defaults */
       GST_DEBUG_OBJECT (overlay, "ALLOCATION query failed");
-      ret = FALSE;
+      allocation_ret = FALSE;
     }

     if (caps_has_meta && gst_query_find_allocation_meta (query,
@@ -792,9 +793,10 @@ gst_base_text_overlay_negotiate (GstBaseTextOverlay *
overlay, GstCaps * caps)

   overlay->attach_compo_to_buffer = attach;

-  if (!ret && overlay->video_flushing) {
+  if ((!ret || !allocation_ret) && overlay->video_flushing) {
     GST_DEBUG_OBJECT (overlay, "negotiation failed, schedule reconfigure");
     gst_pad_mark_reconfigure (overlay->srcpad);
+    ret = FALSE;


It sets allocation_ret to false and then if it failed and video is flushing it
will mark for reconfigure and fail the setcaps. Or am I missing something here?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.