[Bug 735663] dashdemux: synchronize with the download loop thread before signalling it

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735663
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285728|none                        |reviewed
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-12 14:22:29 UTC ---
Review of attachment 285728:
 --> (https://bugzilla.gnome.org/review?bug=735663&attachment=285728)

::: ext/dash/gstdashdemux.c
@@ +430,1 @@
           stream->last_ret = GST_FLOW_CUSTOM_ERROR;

Shouldn't this also be protected by the mutex?

@@ +431,3 @@
+
+          g_mutex_lock (&stream->fragment_download_signaled_lock);
+          stream->fragment_download_signaled = TRUE;

Maybe "download_finished" instead? Also why not just store the flow return here
to distinguish between erorrs and other things?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.