[Bug 733188] review debugging env vars
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Sep 12 07:28:15 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=733188
GStreamer | gstreamer (core) | 1.x
--- Comment #1 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2014-09-12 14:28:11 UTC ---
Created an attachment (id=286047)
View: https://bugzilla.gnome.org/attachment.cgi?id=286047
Review: https://bugzilla.gnome.org/review?bug=733188&attachment=286047
avoid global variable for log_file
As a preparation to refactor some code in gstinfo...
The only concern i have is when calling gst_debug_add_log_function(NULL,
user_data, cleanup) we will implicity use gst_debug_log_default() again, but
now can't ensure user_data to point to the log_file.
I can add a destry_notify function and close the logfile. In addition the code
in
gst_debug_add_log_function() could also run throught he codepath from
_priv_gst_debug_init() to setup a default user_data if that is NULL as well.
Personally I think its overkill :)
Thoughts?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list