[Bug 690646] Cursor offset with ximagesrc and xid

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Sep 15 02:09:04 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=690646
  GStreamer | gst-plugins-good | 1.0.5

--- Comment #23 from Antonio Ospite <ao2 at ao2.it> 2014-09-15 09:09:01 UTC ---
(In reply to comment #22)
> Review of attachment 285482 [details]:
> 
> ::: sys/ximage/gstximagesrc.c
> @@ +214,3 @@
> +    if (coord_translated) {
> +      s->x = x;
> +      s->y = y;
> 
> These should probably be reset to 0 otherwise

OK, I'll do that.

Just to be sure, this is necessary because the object is zeroed only once on
element creation, but the element can survive a start/stop cycle (and/or
get_caps can be called multiple times?), so we can't rely on the initial
zeroing, right?

I am still getting my head around GStreamer.

Thanks,
   Antonio

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list