[Bug 732283] dshowvideosrc: Port to 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732283
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #286292|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-17 07:20:33 UTC ---
Review of attachment 286292:
 --> (https://bugzilla.gnome.org/review?bug=732283&attachment=286292)

Looks almost good, good work :)

::: sys/dshowsrcwrapper/gstdshowaudiosrc.cpp
@@ +247,3 @@
+
+  switch (GST_QUERY_TYPE (query)) {
+    case GST_QUERY_CAPS:

Use GstBaseSrc::get_caps() for this too

@@ +738,3 @@
+          break;
+                case 16:
+          format = GST_AUDIO_FORMAT_S16;

gst_audio_format_build_integer() might be useful here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.