[Bug 736781] New: vc1parse: forge sequence-layer from seq_hdr instead of seq_layer

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736781
  GStreamer | gst-plugins-bad | git

           Summary: vc1parse: forge sequence-layer from seq_hdr instead of
                    seq_layer
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: aurelien.zanelli at parrot.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Hi all,

I found something strange in this vc1parse piece of code:
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst/videoparsers/gstvc1parse.c#n676

When we want VC1_HEADER_FORMAT_ASF + simple/main profile and we don't have
seq_hdr_buffer, we forge it with seq_layer.
But when we want VC1_HEADER_FORMAT_SEQUENCE_LAYER and we don't have a
seq_layer_buffer, we forge it with seq_layer.
Since seq_layer and seq_layer_buffer are set when parsing the sequence-layer,
if we don't have a seq_layer_buffer, we won't have a valid seq_layer.

Therefore, I think it seq_layer_buffer should be forged from seq_hdr but I'm
not sure. What is your opinion ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.