[Bug 736845] videoscale: 4Tap resize support not present for NV format

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736845
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #286438|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-18 09:45:46 UTC ---
Review of attachment 286438:
 --> (https://bugzilla.gnome.org/review?bug=736845&attachment=286438)

::: gst/videoscale/gstvideoscale.c
@@ +407,3 @@
     case GST_VIDEO_SCALE_4TAP:
     {
+      static GstStaticCaps fourtap_filter = GST_STATIC_CAPS
("video/x-raw(ANY)," "format = (string) { RGBx, xRGB, BGRx, xBGR, RGBA, "
"ARGB, BGRA, ABGR, AYUV, ARGB64, AYUV64, " "RGB, BGR, v308, YUY2, YVYU, UYVY, "
"GRAY8, GRAY16_LE, GRAY16_BE, I420, YV12, " "Y444, Y42B, Y41B, RGB16, RGB15,
NV21 }");    // Sanjay. Added NV21

Please indent this properly and add no // comments (git blame can be used for
that information)

@@ +412,3 @@
     case GST_VIDEO_SCALE_LANCZOS:
     {
+      static GstStaticCaps lanczos_filter = GST_STATIC_CAPS
("video/x-raw(ANY)," "format = (string) { RGBx, xRGB, BGRx, xBGR, RGBA, "
"ARGB, BGRA, ABGR, AYUV, ARGB64, AYUV64, " "I420, YV12, Y444, Y42B, Y41B, NV21
}");       // Sanjay. Added NV21

likewise

@@ +1384,3 @@
+        case GST_VIDEO_SCALE_4TAP:
+          vs_image_scale_4tap_Y (&dest[0], &src[0], videoscale->tmp_buf);
+          vs_image_scale_4tap_NV (&dest[1], &src[1], videoscale->tmp_buf);

You add NV12/NV21 to the lanczos caps... but did not implement the scaling for
it.

::: gst/videoscale/vs_4tap.c
@@ +196,2 @@
 void
+vs_scanline_resample_4tap_NV (uint8_t * dest, uint8_t * src,

This should be static

@@ +239,3 @@
+
+void
+vs_scanline_merge_4tap_NV (uint8_t * dest, uint8_t * src1, uint8_t * src2,

And this static too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.