[Bug 736871] codecparsers_vc1: sequence-layer parser is broken due to endianness issue.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736871
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |slomo at coaxion.net
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.5.1

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-18 10:37:33 UTC ---
It's not beautiful but I can't think of a more beautiful way of doing that :)

(also wtf!)

commit bd050201babf995c16181d4ef3a3bd46c261b8be
Author: Aurélien Zanelli <aurelien.zanelli at parrot.com>
Date:   Thu Sep 18 11:39:53 2014 +0200

    vc1parser: add unit test for sequence-layer parsing

    Check that a sequence-layer header is successfully parsed.

    https://bugzilla.gnome.org/show_bug.cgi?id=736871

commit c9a196d54dd41b68473e5a15d17cc37713735147
Author: Aurélien Zanelli <aurelien.zanelli at parrot.com>
Date:   Thu Sep 18 11:49:13 2014 +0200

    vc1parser: take care of endianness when parsing sequence-layer

    sequence-layer is serialized in little-endian byte order except for
    STRUCT_C which is serialized in big-endian byte order.

    But since STRUCT_A and STRUCT_B fields are defined as unsigned int msb
    first, we have to pass them as big-endian to their parsing function. So
    we basically use temporary buffers to convert them in big-endian.

    See SMPTE 421M Annex J and L.

    https://bugzilla.gnome.org/show_bug.cgi?id=736871

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.