[Bug 736877] gsturi: new_uri unused

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Sep 18 07:11:07 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=736877
  GStreamer | gstreamer (core) | git

Luis de Bethencourt <luis.bg> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luis.bg at samsung.com

--- Comment #2 from Luis de Bethencourt <luis.bg at samsung.com> 2014-09-18 14:10:59 UTC ---
Nice! new_uri is unused indeed.

Considering that new_uri is created from the split of the original uri's
protocol and location. And those two never change during the function. new_uri
will always be the same as uri.

Plus this never raised any bugs while it used uri in the iface->set_uri() line.

I think we can just remove the creation of new_uri and we use set_uri. So
number 2 in your list of potential fixes.

As soon as you write this patch I will merge it for you :)

Thanks

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list