[Bug 728646] siren: fix sample list rate

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=728646
  GStreamer | gst-plugins-bad | git

Felix Schwarz <felix.schwarz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |felix.schwarz at oss.schwarz.e
                   |                            |u

--- Comment #3 from Felix Schwarz <felix.schwarz at oss.schwarz.eu> 2014-09-19 13:31:58 UTC ---
Looks good to me too (though I don't have any in-depth knowledge): 
- Wikipedia (https://en.wikipedia.org/wiki/Siren_%28codec%29#Editions) mentions
16, 24 and 32 kbit.

Looking at the code that might imply that flag=1 is siren 7, while flag=2 is
siren 14.

number_of_regions=14 and number_of_coefs=320 for flag=1 matches the G.722
standard as far as I can see
(http://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-G.722.1-200505-I!!SOFT-ZST-E&type=items).

G.722.1 Annex C uses also number_of_coefs=640 which indicates that hypothesis
might be correct. If so I suggest you also update the comment in common.c
("Looks like the flag means what kind of encoding is used").

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.