[Bug 737095] gstqtmux: subtitle muxing doesn't work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737095
  GStreamer | gst-plugins-good | git

--- Comment #2 from Matej Knopp <matej.knopp at gmail.com> 2014-09-21 22:25:24 UTC ---
atom_trak_tx3g_update_dimension:
 - not sure why height is multiplied by 0.15; this doesn't seem right (although
the dimensions are ignored by all players I tested this with)

atom_trak_set_subtitle_commons:
 - subtitle track should have alternate group set; for now set it to 2 for all
subtitles (all other track have zero). 
 - layer should be above video, which has layer 0.

gst_qt_mux_prepare_tx3g_buffer: 
- tx3g buffer should not be null terminated. use strnlen to get actual length
 - buffer duration must be set manually. gst_buffer_copy_into doesn't copy
duration when length differs (seriously though, that's not very intuitive)

gst_qt_mux_add_buffer:
 - should not compute DTS for sparse streams, as the gaps are handled later
using empty buffer

gst_qt_mux_request_new_pad:
 - gst_collect_pads_add_pad should be called with lock = FALSE for sparse
streams, otherwise the pipeline stalls waiting for subtitle buffer that might
not come

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.