[Bug 737138] New: weird error handling code path in audioencoder.c

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737138
  GStreamer | gst-plugins-base | 1.x

           Summary: weird error handling code path in audioencoder.c
    Classification: Platform
           Product: GStreamer
           Version: 1.x
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: ensonic at sonicpulse.de
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


/* advance sample view */
    if (G_UNLIKELY (samples * ctx->info.bpf > priv->offset)) {
      if (G_LIKELY (!priv->force)) {
        /* no way we can let this pass */
        g_assert_not_reached ();
        /* really no way */
        goto overflow;
      } else {

The g_assert_not_reached () ensures that no one ever reaches

overflow:
  {
    GST_ELEMENT_ERROR (enc, STREAM, ENCODE,
        ("received more encoded samples %d than provided %d",
            samples, priv->offset / ctx->info.bpf), (NULL));
    if (buf)
      gst_buffer_unref (buf);
    ret = GST_FLOW_ERROR;
    goto exit;
  }

1) It would be nice to actually log what is wrong
2) and if we use the log line from overflow: make it more descriptive - at
least I can't understand the "received more encoded samples %d than provided
%d" - all the samples the class "receives" are "provided", right?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.