[Bug 737138] weird error handling code path in audioencoder.c

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737138
  GStreamer | gst-plugins-base | 1.x

--- Comment #3 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2014-09-22 19:50:21 UTC ---
It might be more descriptive if it mentions "received more encoded samples than
provided input samples" or something like that, linguistic taste might vary ;-)
And there is something to say for having some debug log in addition to an
assert.
So, perhaps we could move the g_assert_not_reached () to just before the 'goto
exit' (indeed only having an effect in non-release cases).

In any case, it must still be ensured that the subclass is not be claiming that
the encoded data it has produced covers more (raw input) samples than have been
provided to it in the first place.  Well, it might happen at EOS or so, in
which case the 'force' part will allow for that.

Not clear on why this would happen with flac(enc) now.  flacenc has been
working for a long time as a subclass.  Seems then like something
else/more/intricate is going on (and a audiotestsrc ! flacenc ! fakesink still
tests fine here).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.