[Bug 696952] [bin] Implement seek in READY/NULL

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=696952
  GStreamer | gstreamer (core) | git

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #286876|none                        |reviewed
             status|                            |

--- Comment #11 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-09-23 14:31:45 UTC ---
Review of attachment 286876:
 --> (https://bugzilla.gnome.org/review?bug=696952&attachment=286876)

Would like to clarify.

::: gst/gstbin.c
@@ +2859,2 @@
         gst_event_ref (event);
+        tmpres = gst_element_send_event (child, event);

Just checking, is the lock dropped at this point ?

@@ +2861,3 @@
+
+        if (one_sucess_is_enough && tmpres)
+          res = TRUE;

I have doubt this is doing the right thing. Should it be two if, so we never do
res &= when one_success_is_enough ?

if (once_success_is_enough) {
  if (tempret)
    ret = TRUE;
}

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.