[Bug 736926] dshowvideosrc: error if set_caps is called while running

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736926
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #286533|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-23 20:06:51 UTC ---
Review of attachment 286533:
 --> (https://bugzilla.gnome.org/review?bug=736926&attachment=286533)

Yes, should be done for the audio source too. Looks mostly good though

::: sys/dshowsrcwrapper/gstdshowvideosrc.cpp
@@ +582,3 @@
+  GstCaps *current_caps = gst_pad_get_current_caps (pad);
+  gst_object_unref (pad);
+  gboolean same_caps = gst_caps_is_strictly_equal (caps, current_caps);

Put all the variable declarations at the beginning of the block, also a simple
gst_caps_is_equal() is enough here :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.