[Bug 736892] rtpmanager: Removed unwanted variable and assignment

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Sep 23 16:37:05 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=736892
  GStreamer | gst-plugins-good | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #286486|none                        |needs-work
             status|                            |

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-09-23 23:36:57 UTC ---
(From update of attachment 286486)
The problem here is the ret=FALSE assignment which is overwritten again later
by ret=klass->foo without having been used in the  mean time.

I think

  ret = klass->foo();
  return ret;

is not a bad pattern stylistically, don't see why the variable can't stay.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list