[Bug 737127] interleave: interleaving does not respect the channel positions default order

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737127
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #286870|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-09-24 07:54:58 UTC ---
Review of attachment 286870:
 --> (https://bugzilla.gnome.org/review?bug=737127&attachment=286870)

Looks good to me except for some little detail :)

::: gst/interleave/interleave.c
@@ +288,3 @@
+        default_ordering_map[j] = tmp;
+      }
+    }

You could use something like g_qsort_with_data() here, but not really important
other than that we don't have our own sorting here then

::: gst/interleave/interleave.h
@@ +61,3 @@
   gboolean channel_positions_from_input;

+  gint *default_channels_ordering_map;

You can just store a 64 element array here, no need for dynamic allocation

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.