[Bug 737293] dashdemux: fix gst_mpdparser_get_rep_idx_with_max_bandwidth return

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737293
  GStreamer | gst-plugins-bad | 1.4.1

--- Comment #3 from Matthieu Bouron <matthieu.bouron at collabora.com> 2014-09-25 09:32:49 UTC ---
(In reply to comment #2)
> (From update of attachment 287013 [details])
> Does the standard say that it should get the lowest by default? IIRC for HLS it
> gets the first representation in the manifest as default.
> 

I had a quick look at the spec but didn't find any information about which
representation should be used when we do not know the bandwidth yet.

I modified the code to make it consistent with what it is expected according to
the comments in gst_mpdparser_get_rep_idx_with_max_bandwidth which says to get
the lowest representation if bitrate <= 0.

gst_mpdparser_get_rep_idx_with_max_bandwidth now returns -1 and then
gst_mpdparser_get_rep_idx_with_min_bandwidth is called to get the index of the
lowest representation.

IMHO, It feels better/more natural to begin with the lowest stream to avoid
stuttering at the cost of quality.

What do you think ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.