[Bug 737173] h264parse wrongly insert DISCONT flags when converting into AVC

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737173
  GStreamer | gst-plugins-bad | git

Jan Schmidt <thaytan> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at noraisin.net

--- Comment #5 from Jan Schmidt <thaytan at noraisin.net> 2014-09-27 15:16:15 UTC ---
Actually, I wont. I give up - it's all a nasty mess.

If AU delimiters are output, they must be the first thing in the next AU,
according to 7.4.1.2.3 of the spec. They can't be gathered into the previous
AU.

The weird +1 thing comes from commit 6af387cd5ab2c946025e5499903e75ee87b063a9 -
which tries to handle (valid) cases where the start code is only 3 bytes long,
which makes the first loop on the next buffer skip 1 zero byte if there's a
4-byte start code. I don't think that detection code is entirely correct, but
it shouldn't matter - it should be sufficient for the parser to detect a 3-byte
start code, and generate 4-byte start codes where needed. The real problem is
that it's skipping that first byte, which makes base_parse mark things as
discont when they are not. We need a way to make base_parse advance without
making things discont.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.