[Bug 747216] applemedia: CVPixelBufferLockBaseAddress is done too early

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747216

Ilya Konstantinov <ilya.konstantinov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gstreamer-bugs at lists.freede |ilya.konstantinov at gmail.com
                   |sktop.org                   |

--- Comment #3 from Ilya Konstantinov <ilya.konstantinov at gmail.com> ---
Created attachment 300861
  --> https://bugzilla.gnome.org/attachment.cgi?id=300861&action=edit
applemedia: Implement GstCoreVideoMemory

First implementation. Feedback wanted.

SHORTCOMINGS

* Locking was not implemented.
  Can gst_lock_memory be used? I see that GstGlMemory uses a separate mutex.
Why?

* Code reuse.
  * gst_core_media_buffer_wrap_pixel_buffer
  * gst_core_video_buffer_new
  can be probably unified into a helper function in corevideomemory.

* Performance didn't seem to improve noticeably :(

* mem_share not implemented.
  This is bad, right? Isn't this what kills intervideo* performance?

* "GstCoreVideoPlaneMemory.cvmem"
  This looks oddly similar to "GstMemory.parent", in the sense that the plane
memories are supposedly just pointers into the bigger GstCoreVideoMemory.
  Can we switch to using "GstMemory.parent"? How will it affect sharing, if we
choose to implement it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.