[Bug 747270] avfvideosrc: BUFFER_QUEUE_SIZE too small

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747270

--- Comment #6 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
(In reply to Cecill Etheredge (ijsf) from comment #5)
> (In reply to Reynaldo H. Verdejo Pinochet from comment #1)
> > How did you came out with 32? also, are you attaching a patch?
> 
> I'd like to know how you guys came up with 2.

Two make sense if you don't share the data. Basically 1 for the driver to fill,
and 1 for the user space to copy to some other memory location. And then it
loops likes this. But since the code now push the buffers downstream this is
just wrong.

Looking at the code, it's a bit bad. It wrap the memory into a buffer, but used
a GstMeta to actually track the memory lifetime. This is not completly safe. It
also sets the NO_SHARE flags, which will end-up causing copies all over. So
yes, there is a lot of work to do.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.