[Bug 747959] buffer: minimize memory copy in _memory_add()

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Apr 16 03:38:59 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=747959

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
The problem I see here is that it will cause a performance decrease if you add
more memories later after you merged two. Then you will have to merge another
two (which previously might've been three). And then another. And then ...

I think the better solution here is to create an extended GstMemory array that
is used once we get to more than 16 memories. Instead of using the statically
allocated array we could use a GPtrArray once then 17th memory is added, and
maybe for simplicity copy over all pointers from the statically allocated one
and stop using it completely.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list