[Bug 746445] rtpaux: Unit test is racy and producing warnings

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Aug 6 04:17:20 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=746445

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 308758
  --> https://bugzilla.gnome.org/attachment.cgi?id=308758
rtprtxsend: print valid type where guint32 is expected

>From: Hyunjun Ko <zzoon.ko at samsung.com>
>Subject: [PATCH] rtprtxsend: print valid type where guint32 is expected

>       GST_DEBUG_OBJECT (rtx,
>-          "got caps for payload: %d->%d, ssrc: %u->%d: %" GST_PTR_FORMAT,
>-          payload, GPOINTER_TO_INT (rtx_payload), ssrc, data->rtx_ssrc, caps);
>+          "got caps for payload: %d->%d, ssrc: %u->%" G_GUINT32_FORMAT ": %"
>+          GST_PTR_FORMAT, payload, GPOINTER_TO_INT (rtx_payload), ssrc,
>+          data->rtx_ssrc, caps);

For what it's worth, I think %u would probably have been just fine, integer
types <sizeof(int) should get promoted to integer size when being passed
through vararg functions, so I suspect it was just a signed/unsigned mix-up
here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list