[Bug 752808] validate:launcher: unquote the path to support valgrind log file path

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752808

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308876|none                        |rejected
             status|                            |

--- Comment #8 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 308876:
 --> (https://bugzilla.gnome.org/review?bug=752808&attachment=308876)

::: validate/launcher/utils.py
@@ -142,2 +142,2 @@
 def path2url(path):
-    return urlparse.urljoin('file:', urllib.pathname2url(path))
+    return urlparse.urljoin('file:',
urllib.unquote(urllib.pathname2url(path)))

It is not correct to unquote the 'path' part of the url. The URL should be
quoted.

@@ -149,3 @@
         if path[0] == '/':
             return path[1:]  # We need to remove the first '/' on windows
-    path = urllib.unquote(path)

Here it is correct to unquote

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.