[Bug 752413] dashdemux: add support for parsing UTCTiming elements

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Aug 10 04:48:25 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=752413

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to A Ashley from comment #8)
> (In reply to Sebastian Dröge (slomo) from comment #7)
> > Review of attachment 309003 [details] [review] [review]:
> > 
> > ::: ext/dash/gstdashdemux.c
> > @@ +1228,3 @@
> >    GstDashDemux *dashdemux = GST_DASH_DEMUX_CAST (demux);
> > +  return MIN (dashdemux->client->mpd_node->minimumUpdatePeriod * 1000,
> > +      CLOCK_UPDATE_INTERVAL);
> > 
> > Hm but this means that we will also update the manifest each time, right?
> > Which might mean that we update the manifest too often, and a server might
> > complain about that
> 
> Yes it does. However the clock poll is set to 30 minutes, so it's not going
> to add much traffic.

Ah I misunderstood that part of the code... there's only going to be a problem
if the minimum update period is bigger than 30 minutes, and if the server
enforces that (client refreshes earlier? block it!). Seems unlikely.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list