[Bug 753490] audioecho: reallocate buffer on changing max_delay

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Aug 13 21:18:02 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=753490

--- Comment #3 from Prashant Gotarne <ps.gotarne at samsung.com> ---
Created attachment 309239
  --> https://bugzilla.gnome.org/attachment.cgi?id=309239&action=edit
audioecho: patch to free buffer unconditionally

Thanks for the review.
I kept it conditionally to avoid possible reallocations if max_delay is less
than the old value.  

Also in PROP_DELAY case, max_delay value in else block will change only if
element is in NULL state or READY state. In this case the buffer is already
NULL so no need to do anything.

To minimize the memory usage your suggestion to free the buffer unconditionally
is right :-) 
I will attach another patch as per your review comments. I will keep the older
patch as it is; in case you want to go with the conditional approach to avoid
reallocation.

Please review it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list